Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide alternative rustic mode that derives from rust-ts-mode #480

Merged
merged 2 commits into from
Dec 28, 2022
Merged

provide alternative rustic mode that derives from rust-ts-mode #480

merged 2 commits into from
Dec 28, 2022

Conversation

brotzeit
Copy link
Owner

@brotzeit brotzeit commented Dec 26, 2022 •
edited
Loading

@brotzeit brotzeit force-pushed the treesit branch 2 times, most recently from 6f0748c to a2c1b6b Compare December 27, 2022 15:36
psibi
psibi reviewed Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

README.md Show resolved Hide resolved
@brotzeit brotzeit force-pushed the treesit branch 2 times, most recently from 0af0943 to 517bb68 Compare December 27, 2022 15:58
@brotzeit
Copy link
Owner Author

Ok let's give it a try. Shouldn't break anything, hopefully =)

@brotzeit brotzeit merged commit a8f41bd into master Dec 28, 2022
@brotzeit brotzeit deleted the treesit branch December 28, 2022 11:23
@brotzeit
Copy link
Owner Author

I'll revert it for now. Seems I only tested it with emacs master. I'll check again.

@brotzeit brotzeit mentioned this pull request Dec 29, 2022
Merged
@brotzeit
Copy link
Owner Author

The issue was probably that I tagged the variable with emacs29 afterwards...

@brotzeit brotzeit mentioned this pull request Feb 14, 2023
Open
@CeleritasCelery
Copy link
Contributor

Now that Emacs 29 is official released. Can this be merged again?

@qiyan2019
Copy link

@brotzeit Emacs 29 is official released, treesit should be supported?

@dertuxmalwieder
Copy link

dertuxmalwieder commented Aug 15, 2023 •
edited
Loading

I'll +1 here. I would like to slowly migrate to rust-ts-mode (and others), but Rustic is a great help, so I would like those two to play together well. Right now, I just aliased rust-mode and nothing seems to be FUBAR yet, but this is inelegant.

@failable
Copy link

+1

psibi added a commit that referenced this pull request Aug 18, 2023
@psibi
Re-add rustic mode based on rustic-ts (Treesitter support)
63293f1 
This code is based on #480, but
there are some changes based on my testing.
@psibi psibi mentioned this pull request Aug 18, 2023
Open
@psibi
Copy link
Collaborator

psibi commented Aug 18, 2023

@liebkne and others: Can you give this a try and see how it goes: #527 ? I have been using it for a day and seems to be working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psibi psibi psibi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brotzeit @CeleritasCelery @qiyan2019 @dertuxmalwieder @failable @psibi